Skip to content

use array concatenation instead of push in useFlattenRecords hook #984

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 9, 2023
Merged

use array concatenation instead of push in useFlattenRecords hook #984

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5c5e476
use array concatenation instead of push in useFlattenRecords hook
vlats05 Apr 21, 2023
4744208
use array concatenation instead of push in useFlattenRecords hook
vlats05 Apr 21, 2023
3a5df32
add change description
vlats05 Apr 22, 2023
3813de3
Merge remote-tracking branch 'origin/master'
vlats05 Apr 22, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 5 additions & 2 deletions src/hooks/useFlattenRecords.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -60,13 +60,16 @@ export default function useFlattenRecords<T>(
) {
const arr: { record: T; indent: number; index: number }[] = React.useMemo(() => {
if (expandedKeys?.size) {
const temp: { record: T; indent: number; index: number }[] = [];
let temp: { record: T; indent: number; index: number }[] = [];

// collect flattened record
for (let i = 0; i < data?.length; i += 1) {
const record = data[i];

temp.push(...flatRecord<T>(record, 0, childrenColumnName, expandedKeys, getRowKey, i));
// using array.push or spread operator may cause "Maximum call stack size exceeded" exception if array size is big enough.
temp = temp.concat(
...flatRecord<T>(record, 0, childrenColumnName, expandedKeys, getRowKey, i),
);
}

return temp;
Expand Down