Fix active bar render bug #104
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
when initialize, usually happend with css-loader close ant-design/ant-design#7564 close ant-design/ant-design#8000 close ant-design/ant-design#8001 close ant-tool/atool-doc#40 close dvajs/dva#1300
benjycui
reviewed
Oct 27, 2017
| // If there is no css rendered, don't generate the ink bar | ||
| // fix https://github.com/ant-design/ant-design/issues/8001 | ||
| if (document.styleSheets.length === 0 || | ||
| (document.styleSheets.length === 1 && document.styleSheets[0].rules.length === 0)) { |
There was a problem hiding this comment.
这里或者应该用 document.styleSheets.every(s => s.rules.length === 0) ??
|
Reverted |
This was referenced Oct 27, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix tab active ink bar is rendered too long, when initialize, usually happend with css-loader
close ant-design/ant-design#7564
close ant-design/ant-design#8000
close ant-design/ant-design#8001
close ant-tool/atool-doc#40
close dvajs/dva#1300