Skip to content

Fix active bar render bug #104

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Oct 26, 2017
Merged

Fix active bar render bug #104

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4f0d910
remove blank
afc163 Oct 26, 2017
fdf7858
Fix tab active ink bar is rendered too long
afc163 Oct 26, 2017
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 6 additions & 1 deletion src/InkTabBarMixin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -38,6 +38,12 @@ function offset(elem) {
}

function componentDidUpdate(component, init) {
// If there is no css rendered, don't generate the ink bar
// fix https://github.com/ant-design/ant-design/issues/8001
if (document.styleSheets.length === 0 ||
(document.styleSheets.length === 1 && document.styleSheets[0].rules.length === 0)) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

这里或者应该用 document.styleSheets.every(s => s.rules.length === 0) ??

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

document.styleSheets 不是一个数组

return;
}
const { styles } = component.props;
const wrapNode = component.nav || component.root;
const containerOffset = offset(wrapNode);
Expand Down Expand Up @@ -98,7 +104,6 @@ function componentDidUpdate(component, init) {
}

export default {

getDefaultProps() {
return {
inkBarAnimated: true,
Expand Down