fix: cannot find parent container error in prod mode #134
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
afc163
reviewed
Aug 5, 2018
src/InkTabBarNode.js
Outdated
|
|
||
| const isDev = process.env.NODE_ENV !== 'production'; | ||
| let isDev = process.env.NODE_ENV !== 'production'; | ||
| isDev = true; |
|
test 挂了，在修 |
picodoth
force-pushed
the
issue-130
branch
3 times, most recently
from
2c73c9b to
e94082c
Compare
|
ready 了 |
src/TabBarRootNode.js
Outdated
| componentDidMount() { | ||
| // child inktabbar depends on parent ref | ||
| // so in mounting phase, we render parent first and then children | ||
| this.didMount = true; |
picodoth
commented
Aug 5, 2018
| class="rc-tabs-nav" | ||
| className="rc-tabs-nav" | ||
| > | ||
| <undefined /> |
picodoth
commented
Aug 5, 2018
| class="rc-tabs-nav" | ||
| className="rc-tabs-nav" | ||
| > | ||
| <undefined /> |
|
这里是不是还是 setTimeout 的方法好一些，ScrollableTabBarNode 和 SwipeableTabBarNode 也有类似的情况，我们要不然每一层都得做，要不然得动态判断下一层孩子有没有 InkTabBarNode |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#130