Skip to content

fix: cannot find parent container error in prod mode #134

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Aug 6, 2018
Merged

fix: cannot find parent container error in prod mode #134

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
f019ea0
fix: cannot find parent container error in prod mode
picodoth Aug 5, 2018
a3e4af6
Revert "fix: cannot find parent container error in prod mode"
picodoth Aug 6, 2018
a43ab51
fix: use setTimeout as a quick fix to do calculation after parent mou…
picodoth Aug 6, 2018
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
17 changes: 8 additions & 9 deletions src/InkTabBarNode.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,8 +3,6 @@ import PropTypes from 'prop-types';
import classnames from 'classnames';
import { setTransform, isTransformSupported } from './utils';

const isDev = process.env.NODE_ENV !== 'production';

export function getScroll(w, top) {
let ret = w[`page${top ? 'Y' : 'X'}Offset`];
const method = `scroll${top ? 'Top' : 'Left'}`;
Expand Down Expand Up @@ -109,14 +107,15 @@ function componentDidUpdate(component, init) {

export default class InkTabBarNode extends React.Component {
componentDidMount() {
if (isDev) {
// https://github.com/ant-design/ant-design/issues/8678
this.timeout = setTimeout(() => {
componentDidUpdate(this, true);
}, 0);
} else {
// ref https://github.com/ant-design/ant-design/issues/8678
// ref https://github.com/ant-design/ant-design/issues/11612
// InkTabBarNode need parent/root ref for calculating position
// since parent componentDidMount triggered after child componentDidMount
// we're doing a quick fix here to use setTimeout to calculate position
// after parent/root component mounted
this.timeout = setTimeout(() => {
componentDidUpdate(this, true);
}
}, 0);
}

componentDidUpdate() {
Expand Down