Skip to content

Conversation

DavidSichau
Copy link
Contributor

@afc163 I am really sorry to bother you again, I made an error in the title. This pull request is similar to openFileDialogOnClick but this prevents to open the fileDialog on Enter.

This is useful if one for example wants to add drag and drop upload to a editor component, where the enter key is used for new lines.

@afc163
Copy link
Member

afc163 commented May 8, 2019

😢 I made a mistake, it is so similar.

@coveralls
Copy link

coveralls commented May 8, 2019

Coverage Status

Coverage remained the same at 82.353% when pulling 8a32333 on DavidSichau:master into 4997be2 on react-component:master.

@afc163
Copy link
Member

afc163 commented May 8, 2019

image

@afc163
Copy link
Member

afc163 commented May 8, 2019

I think we can turn off keyboard behavior too when openFileDialogOnClick is false, no need to add another prop.

@DavidSichau
Copy link
Contributor Author

Ok I will make the change.

@DavidSichau
Copy link
Contributor Author

The changes are in the pull request: #182

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants