Skip to content

chore: Pass invalidate type #320

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
May 17, 2021
Merged

chore: Pass invalidate type #320

merged 3 commits into from
May 17, 2021

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented May 17, 2021

发个 minor 版本

ref ant-design/ant-design#30403

@zombieJ zombieJ requested review from afc163 and kerm1it May 17, 2021 03:59
@vercel
Copy link

vercel bot commented May 17, 2021

This pull request is being automatically deployed with Vercel (learn more).
To see the status of your deployment, click below or on the icon next to each commit.

🔍 Inspect: https://vercel.com/react-component/upload/DJNcMkXmUrZxoxUy8LBJbTK2yZqY
✅ Preview: https://upload-git-fix-check-react-component.vercel.app

@codecov
Copy link

codecov bot commented May 17, 2021

Codecov Report

Merging #320 (d57f498) into master (8747865) will increase coverage by 0.31%.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #320      +/-   ##
==========================================
+ Coverage   84.48%   84.80%   +0.31%     
==========================================
  Files           6        6              
  Lines         245      250       +5     
  Branches       58       60       +2     
==========================================
+ Hits          207      212       +5     
  Misses         38       38              
Impacted Files Coverage Δ
src/attr-accept.ts 96.42% <100.00%> (+0.77%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 8747865...d57f498. Read the comment docs.

return mimeType === validType;

// Full match
if (mimeType === validType) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

想到一个问题,如果用户写成 image/jpg 是不是匹配不到 jpg 图?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

嗯,不过如果都写 image/xxx 了。这个应该就按照标准的来了。

@zombieJ zombieJ merged commit a983bfa into master May 17, 2021
@zombieJ zombieJ deleted the fix-check branch May 17, 2021 08:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants