Skip to content

Conversation

zombieJ
Copy link
Member

@zombieJ zombieJ commented Aug 22, 2023

max end should be data.length - 1

@vercel
Copy link

vercel bot commented Aug 22, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
virtual-list ❌ Failed (Inspect) Aug 22, 2023 5:59am

@codecov
Copy link

codecov bot commented Aug 22, 2023

Codecov Report

Merging #224 (a960d6c) into master (282f9b6) will not change coverage.
The diff coverage is 100.00%.

❗ Current head a960d6c differs from pull request most recent head 2c11ebd. Consider uploading reports for the commit 2c11ebd to get more accurate results

@@           Coverage Diff           @@
##           master     #224   +/-   ##
=======================================
  Coverage   99.50%   99.50%           
=======================================
  Files          17       17           
  Lines         603      603           
  Branches      125      125           
=======================================
  Hits          600      600           
  Misses          3        3           
Files Changed Coverage Δ
src/List.tsx 99.46% <100.00%> (ø)

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@afc163
Copy link
Member

afc163 commented Aug 22, 2023

原始问题是啥

@zombieJ
Copy link
Member Author

zombieJ commented Aug 22, 2023

原始问题是啥

就是测试用例的那个 extraRender 里的 info 发现 end 超出 data.length 了。

rc-table 里取 dataSource[end] 空对象报错,回来发现的。

@zombieJ zombieJ merged commit d312fb3 into master Aug 22, 2023
@zombieJ zombieJ deleted the fix-render branch August 22, 2023 06:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants