Skip to content
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/List.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -239,7 +239,7 @@ export function RawList<T>(props: ListProps<T>, ref: React.Ref<ListRef>) {
}

// Give cache to improve scroll experience
endIndex = Math.min(endIndex + 1, mergedData.length);
endIndex = Math.min(endIndex + 1, mergedData.length - 1);

return {
scrollHeight: itemTop,
Expand Down
30 changes: 30 additions & 0 deletions tests/scroll.test.js
Original file line number Diff line number Diff line change
Expand Up @@ -336,4 +336,34 @@ describe('List.Scroll', () => {

expect(spyPreventDefault).toHaveBeenCalled();
});

it('scroll to end should not has wrong extraRender', () => {
const extraRender = jest.fn(({ start, end }) => {
return null;
});

jest.useFakeTimers();
const { container } = genList(
{
itemHeight: 20,
height: 100,
data: genData(100),
extraRender,
},
render,
);

const holder = container.querySelector('ul');

const event = createEvent.wheel(holder, {
deltaY: 99999999999999999999,
});
fireEvent(holder, event);

act(() => {
jest.runAllTimers();
});

expect(extraRender).toHaveBeenCalledWith(expect.objectContaining({ end: 99 }));
});
});