Skip to content

Migrate Windows test app to react-native-test-app #524

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jan 29, 2021
Merged

Migrate Windows test app to react-native-test-app #524

merged 2 commits into from
Jan 29, 2021

Conversation

tido64
Copy link
Member

@tido64 tido64 commented Jan 16, 2021 •
edited
Loading

Summary

Migrates Windows test app to react-native-test-app.

Remaining Work

Test Plan

  1. Build Windows example app: 
    yarn
yarn install-windows-test-app -p example/windows
start example/windows/ReactTestApp.sln
yarn start:windows
  2. Make sure the app works as expected

Screenshots

Since we're also bumping react-native, we should also make sure we haven't broken other platforms.

Android iOS macOS Windows
Screenshot_1611676595 Simulator Screen Shot - iPhone 12 Pro - 2021-01-26 at 16 46 56 Screenshot 2021-01-26 at 16 52 08 image

@tido64 tido64 added the platform: Windows This is Windows specific label Jan 16, 2021
@tido64 tido64 force-pushed the tido64/migrate-windows-test-app branch from 755ebe1 to e916f4e Compare January 19, 2021 15:45
@tido64 tido64 force-pushed the tido64/migrate-windows-test-app branch 4 times, most recently from b2aecbf to cac9104 Compare January 25, 2021 13:23
@tido64 tido64 force-pushed the tido64/migrate-windows-test-app branch from cac9104 to 4594d42 Compare January 26, 2021 23:24
@tido64 tido64 force-pushed the tido64/migrate-windows-test-app branch from 4594d42 to c3a22f9 Compare January 26, 2021 23:27
@tido64 tido64 requested a review from krizzu January 26, 2021 23:48
@tido64 tido64 marked this pull request as ready for review January 26, 2021 23:48
krizzu
krizzu approved these changes Jan 28, 2021
View reviewed changes
Copy link
Member

@krizzu krizzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great work 💪

@tido64 tido64 merged commit 814cb72 into master Jan 29, 2021
@tido64 tido64 deleted the tido64/migrate-windows-test-app branch January 29, 2021 07:04
@krizzu
Copy link
Member

krizzu commented Jan 29, 2021

🎉 This PR is included in version 1.13.4 🎉

The release is available on:

Your semantic-release bot 📦🚀

@dependabot dependabot bot mentioned this pull request Mar 15, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@krizzu krizzu krizzu approved these changes

Assignees
No one assigned
Labels
platform: Windows This is Windows specific
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@tido64 @krizzu