Skip to content

Conversation

developer239
Copy link
Contributor

No description provided.

@crazypixel
Copy link

when do you plan to merge it ?

@almostintuitive
Copy link

hey!

this is unfortunately blocking us using this library. it'd be great to merge it in!

@developer239
Copy link
Contributor Author

Not sure if I fixed all of the problems though.

@Benornm
Copy link

Benornm commented Jul 25, 2017

why the react-native-community not raising the glove and fix this issue ?

@magicismight
Copy link
Contributor

I'm not sure this would fix the problem for good.

import createReactNativeComponentClass from 'react-native/Libraries/Renderer/shims/createReactNativeComponentClass.js'; should works the same as +import createReactNativeComponentClass from 'react-native/Libraries/Renderer/shims/createReactNativeComponentClass

Could you update your package.json's dependencies and npm install?

"dependencies": {
		"react": "16.0.0-alpha.12",
		"react-native": "0.46.4",
		"react-native-svg": "5.3.2"
	},

@magicismight
Copy link
Contributor

$ npm ls react-native-svg
test@0.0.1
└── react-native-svg@5.3.2 

$ npm ls react-native
test@0.0.1
└── react-native@0.46.4 

$ npm ls react
test@0.0.1
└── react@16.0.0-alpha.12 

This works fine for me.

@almostintuitive
Copy link

Hi! What's the current status of this PR?

@markentingh
Copy link

please merge this so we can start using SVGs in our projects

@luco
Copy link

luco commented Jul 31, 2017

I had to put import createReactNativeComponentClass from 'react-native/Libraries/Renderer/src/renderers/native/createReactNativeComponentClass.js';

Any tips?

@magicismight magicismight merged commit 378262d into software-mansion:master Aug 3, 2017
@magicismight
Copy link
Contributor

Thanks for this PR.
Have this landed on 5.3.3.
But I didn't feature out why this works.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants