-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Add rtl support for swipe #740
Conversation
This is huge! Thanks for the PR. I tested it and it works. There's a small issue where the screen shakes when you touch it or when you lift your finger. |
The issue that @satya164 just mentioned is because of this line I used |
Ok, I spent many hours to solve this issue and I'm stuck in it. I figure out I should multiply this._velocityX to -1 in RTL mode for spring animation, but it's get me an error for prop type require. I spent plenty time to solve this but I'm stuck in it. also I figure out the index calculated and sent to translateX ( in both rtl and ltr ) calculate multi time and for example when I swipe from index 0 to index 1, base on velocity Its maybe plus two time and the calculate value will be 2 in some time. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
or maybe not 🤔 |
@AliAzizi we'll look into it. thanks again for the PR :) |
Your welcome, |
Change pager.js swipe controll for rtl support
Motivation
Enable swipping for rtl language
Test plan