Fix: Functionality to close the BottomSheet #2507
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
saxenanihal95
force-pushed
the
bottom_sheet_changes
branch
from
9ebc723 to
15f8d15
Compare
Codecov Report
@@ Coverage Diff @@
## next #2507 +/- ##
==========================================
- Coverage 93.10% 93.03% -0.08%
==========================================
Files 40 40
Lines 769 761 -8
Branches 115 113 -2
==========================================
- Hits 716 708 -8
Misses 49 49
Partials 4 4
Continue to review full report at Codecov.
|
saxenanihal95
force-pushed
the
bottom_sheet_changes
branch
from
15f8d15 to
fc0ff58
Compare
saxenanihal95
changed the title
Contributor
|
This looks like a much needed change! Question: is the |
Contributor
Author
|
@JoeDuncko Yes i was first thinking to provide |
saxenanihal95
force-pushed
the
bottom_sheet_changes
branch
from
fc0ff58 to
1702c0a
Compare
flyingcircle
requested changes
Aug 16, 2020
* Removed Button component as it is tightly coupled to BottomSheet Component * Exposed isVisible prop so that user can easily manage BottomSheet Component visibililty
saxenanihal95
force-pushed
the
bottom_sheet_changes
branch
from
1702c0a to
6e5470d
Compare
Contributor
|
Cool, that makes more sense to me now. I think it's a good first step to a much more useful |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #2505
Removed Button component as it is tightly coupled
to BottomSheet Component
Exposed isVisible prop so that user can easily
manage BottomSheet Component visibililty