Add custom control option for RuleGroup component #141
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #141 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 13 13
Lines 267 267
Branches 23 23
=========================================
Hits 267 267
Continue to review full report at Codecov.
|
jakeboone02
requested changes
Jun 11, 2020
|
@jakeboone02 Thanks for your comments, I'm fixing that. It doesn't fix #133, only RuleGroup is now customizable. But I saw that artenator did it on his fork, he could make a Pull Request for it. |
jakeboone02
approved these changes
Jun 12, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request allow to customize the RuleGroup component. As Rule component is a part of it, it's now accessible when using this module. Furthermore, I fixed an issue with copy-webpack-plugin (caused by the recent package upgrade).