Separate theme related Sass variables from other settings #220
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adamkudrna
force-pushed
the
refactoring/theme-variables
branch
from
460c3e6 to
d373308
Compare
bedrich-schindler
approved these changes
Feb 2, 2021
adamkudrna
force-pushed
the
refactoring/theme-variables
branch
from
d373308 to
9b722ad
Compare
adamkudrna
force-pushed
the
refactoring/theme-variables
branch
from
9b722ad to
cff45ee
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of this change is that we store all
--rui-(!local)-*(theme) custom property calls as Sass variables in thestyles/themedirectory. Other Sass variables may reuse these variables but from now on the theme custom properties should be called only here.