Skip to content

Separate theme related Sass variables from other settings #220

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 2, 2021
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/docs/_components/Placeholder/Placeholder.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../../lib/styles/settings/colors';
@use '../../../lib/styles/theme/colors';
@use '../../../lib/styles/tools/spacing';

.root {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/layout/FormLayout/FormLayout.scss
Original file line number Diff line number Diff line change
Expand Up @@ -13,8 +13,8 @@
// (a global default which can be customised per use).

@use '../../../styles/settings/forms' as settings;
@use '../../../styles/settings/forms-theme' as theme;
@use '../../../styles/settings/layouts';
@use '../../../styles/theme/forms' as theme;
@use '../../../styles/tools/breakpoint';

.root {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Alert/Alert.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../../styles/settings/typography';
@use '../../../styles/theme/typography';
@use '../../../styles/tools/reset';
@use 'settings';
@use 'theme';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Alert/_settings.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../../styles/settings/typography';
@use '../../../styles/theme/typography';
@use 'theme';

$font-size: map-get(typography.$size-values, 0);
Expand Down
6 changes: 3 additions & 3 deletions src/lib/components/ui/Badge/Badge.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../../../styles/settings/borders';
@use '../../../styles/settings/colors';
@use '../../../styles/settings/typography';
@use '../../../styles/theme/borders';
@use '../../../styles/theme/colors';
@use '../../../styles/theme/typography';

$_badge-size: 1.25rem;

Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Button/_settings.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../../styles/settings/typography';
@use '../../../styles/theme/typography';
@use '../../../styles/tools/spacing';

$font-family: typography.$font-family-base;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/CheckboxField/CheckboxField.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '../../../styles/settings/borders';
@use '../../../styles/settings/forms.deprecated' as deprecated-settings;
@use '../../../styles/theme/borders';
@use '../../../styles/tools/accessibility';
@use '../../../styles/tools/forms/foundation';
@use '../../../styles/tools/forms.deprecated' as deprecated-tools;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Modal/Modal.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../../styles/settings/typography';
@use '../../../styles/theme/typography';
@use '../../../styles/tools/breakpoint';
@use '../../../styles/tools/reset';
@use '../../../styles/tools/spacing';
Expand Down
4 changes: 2 additions & 2 deletions src/lib/components/ui/Modal/_settings.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../../../styles/settings/borders';
@use '../../../styles/settings/typography';
@use '../../../styles/settings/z-indexes';
@use '../../../styles/theme/borders';
@use '../../../styles/theme/typography';
@use '../../../styles/tools/spacing';

$padding-x: spacing.of(5);
Expand Down
6 changes: 3 additions & 3 deletions src/lib/components/ui/Table/_settings.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../../../styles/settings/borders';
@use '../../../styles/settings/colors';
@use '../../../styles/settings/typography';
@use '../../../styles/theme/borders';
@use '../../../styles/theme/colors';
@use '../../../styles/theme/typography';
@use '../../../styles/tools/spacing';

$cell-padding-x: spacing.of(3);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/components/ui/Toggle/Toggle.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use '../../../styles/settings/borders';
@use '../../../styles/settings/colors.deprecated' as deprecated-colors;
@use '../../../styles/settings/forms.deprecated' as deprecated-settings;
@use '../../../styles/theme/borders';
@use '../../../styles/tools/accessibility';
@use '../../../styles/tools/forms/foundation';
@use '../../../styles/tools/forms.deprecated' as deprecated-tools;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/elements/_code.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../settings/colors';
@use '../theme/colors';

code {
padding: 0.15em 0.5em;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/elements/_links.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../settings/links';
@use '../theme/links';

a {
text-decoration: links.$decoration;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/elements/_lists.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../settings/lists';
@use '../theme/lists';

ol,
ul {
Expand Down
4 changes: 2 additions & 2 deletions src/lib/styles/elements/_page.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '../settings/page';
@use '../settings/typography';
@use '../theme/page';
@use '../theme/typography';

html {
width: 100%;
Expand Down
4 changes: 2 additions & 2 deletions src/lib/styles/elements/_rulers.scss
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
@use '../settings/borders';
@use '../settings/colors';
@use '../theme/borders';
@use '../theme/colors';

hr {
border: 0;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/elements/_small.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../settings/typography';
@use '../theme/typography';

small {
font-size: typography.$size-small;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/settings/_forms.deprecated.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
// ⚠️ Deprecated for new components.

@use 'colors';
@use '../theme/colors';
@use 'colors.deprecated' as deprecated-colors;

$form-focus-outline-color: deprecated-colors.$blue-lighter;
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/settings/_forms.scss
Original file line number Diff line number Diff line change
@@ -1,8 +1,8 @@
// 1. Input `line-height` is specified in `rem` so inputs do not break when their font size gets
// changed later.

@use '../theme/typography';
@use '../tools/spacing';
@use 'typography';

$field-font-family: typography.$font-family-base;
$field-font-weight: map-get(typography.$font-weight-values, regular);
Expand Down
6 changes: 3 additions & 3 deletions src/lib/styles/settings/_utilities.scss
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
@use 'colors';
@use 'spacing';
@use 'typography';
@use '../theme/colors';
@use '../theme/spacing';
@use '../theme/typography';

$map: (
'display': (
Expand Down
File renamed without changes.
Original file line number Diff line number Diff line change
@@ -1,5 +1,5 @@
// Variant specific theme options are obtained dynamically because there is way too many of them to
// maintain manually. See `tools/forms/_variants.scss` for details.
// maintain manually. See `settings/_forms.scss` and `tools/forms/_variants.scss` for details.

$field-input-width: var(--rui-form-field-input-width);
$field-input-min-width: var(--rui-form-field-input-min-width);
Expand Down
File renamed without changes.
File renamed without changes.
File renamed without changes.
2 changes: 1 addition & 1 deletion src/lib/styles/tools/_forms.deprecated.scss
Original file line number Diff line number Diff line change
@@ -1,9 +1,9 @@
// ⚠️ Deprecated for new components.

@use '../settings/borders';
@use '../settings/colors.deprecated' as deprecated-colors;
@use '../settings/forms' as settings;
@use '../settings/forms.deprecated' as deprecated-settings;
@use '../theme/borders';
@use 'breakpoint';

@mixin disabled-state() {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/tools/_spacing.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../settings/spacing';
@use '../theme/spacing';

@function of($value) {
@if ($value % 1 != 0) {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/tools/forms/_foundation.scss
Original file line number Diff line number Diff line change
Expand Up @@ -8,7 +8,7 @@
// 6. Don't let text alignment be affected by a parent.

@use '../../settings/forms' as settings;
@use '../../settings/forms-theme' as theme;
@use '../../theme/forms' as theme;
@use '../../tools/caret';
@use '../spacing';
@use '../transition';
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/tools/forms/_layouts.scss
Original file line number Diff line number Diff line change
Expand Up @@ -32,7 +32,7 @@
// for more.

@use '../../settings/forms' as settings;
@use '../../settings/forms-theme' as theme;
@use '../../theme/forms' as theme;
@use '../breakpoint';

@mixin field-layout-vertical() {
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/tools/forms/_sizes.scss
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
@use '../../settings/forms-theme' as theme;
@use '../../theme/forms' as theme;

@mixin field-size($size, $is-multiline: false) {
$size-properties: map-get(theme.$field-sizes, $size);
Expand Down
2 changes: 1 addition & 1 deletion src/lib/styles/tools/forms/_variants.scss
Original file line number Diff line number Diff line change
Expand Up @@ -9,8 +9,8 @@
// 3. `.input:focus` is added just in case `:focus-within` doesn't work.

@use 'sass:list';
@use '../../settings/forms-theme' as theme;
@use '../../settings/forms' as settings;
@use '../../theme/forms' as theme;

@mixin _disabled-state() {
opacity: theme.$field-disabled-opacity;
Expand Down