Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add cart item subtotal to CartItem component #240

Closed
cassytaylor opened this issue Aug 20, 2018 · 1 comment · Fixed by #483
Closed

Add cart item subtotal to CartItem component #240

cassytaylor opened this issue Aug 20, 2018 · 1 comment · Fixed by #483
Assignees
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug

Comments

@cassytaylor
Copy link

cassytaylor commented Aug 20, 2018

Issue

Due to oversight during the design process (sorry), total item price is unclear in the cart.
The total price of an item isn't reflected when the quantity is 2+ in the cart, only the "each" quantity.
Screen Shot 2018-08-20 at 5.40.37 PM.png
There should be a line showing the total cost for the watches (5 x $699.99)

Solution

The total price per item should be reflected in the cart.
Desktop mock: http://zpl.io/aRq4xQg
Mobile: http://zpl.io/VQqNR4A

screen shot 2018-08-21 at 12 25 48 pm

@cassytaylor cassytaylor added the bug For issues that describe a defect or regression in the released software label Aug 20, 2018
@aldeed aldeed added this to the Little Bear milestone Aug 21, 2018
@spencern spencern modified the milestones: Little Bear, Massive Sep 4, 2018
@spencern spencern modified the milestones: Massive, North Maroon Sep 18, 2018
@aldeed aldeed removed the bug For issues that describe a defect or regression in the released software label Sep 18, 2018
@aldeed aldeed changed the title Item prices (price each vs. total price) is unclear in Cart / Minicart Add cart item subtotal to CartItem component Sep 18, 2018
@aldeed
Copy link
Contributor

aldeed commented Sep 18, 2018

The necessary data comes from GraphQL in CartItem.subtotal.displayAmount

@spencern spencern modified the milestones: North Maroon, Oxford Oct 2, 2018
@spencern spencern added the enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug label Oct 18, 2018
@spencern spencern removed this from the Oxford milestone Oct 18, 2018
@machikoyasuda machikoyasuda self-assigned this Nov 20, 2018
nnnnat added a commit that referenced this issue Nov 29, 2018
This was referenced Jan 15, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement For issues that describe a feature that needs to be added, changed, or removed, but is not a bug
Projects
None yet
Development

Successfully merging a pull request may close this issue.

4 participants