Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

#240: Add subtotal to CartItems #437

Merged
merged 3 commits into from
Nov 29, 2018
Merged

#240: Add subtotal to CartItems #437

merged 3 commits into from
Nov 29, 2018

Conversation

machikoyasuda
Copy link
Contributor

@machikoyasuda machikoyasuda commented Nov 28, 2018 •
edited
Loading

Resolves #240
Impact: minor
Type: feature

Issue

  • When the quantity of a product in a cart is more than 1, the price does not reflect the total price.

Solution

  • Update to latest Components version
  • Add subtotal to Carts query

Testing

  1. Test in MiniCart
  2. Test in Cart
  3. Test in Checkout
  4. Test on Thank you page
  5. Test on mobile

screen shot 2018-11-28 at 3 16 58 pm

screen shot 2018-11-28 at 2 47 36 pm

screen shot 2018-11-28 at 2 47 42 pm

screen shot 2018-11-28 at 3 05 14 pm

screen shot 2018-11-28 at 3 06 05 pm

nnnnat
nnnnat approved these changes Nov 29, 2018
View reviewed changes
Copy link
Contributor

@nnnnat nnnnat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💯 LGTM!!

@nnnnat nnnnat merged commit f612357 into develop Nov 29, 2018
@nnnnat nnnnat deleted the 240-machikoyasuda-cartitems-subtotal branch November 29, 2018 22:10
This was referenced Jan 15, 2019
Closed
Merged
@spencern spencern mentioned this pull request Jan 25, 2019
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nnnnat nnnnat nnnnat approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@machikoyasuda @nnnnat