Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: promotion disabled but still can appliable #6763

Merged
merged 1 commit into from
Jan 17, 2023

Conversation

vanpho93
Copy link
Member

Resolves #6757
Impact: minor
Type: bugfix

@changeset-bot
Copy link

changeset-bot bot commented Jan 16, 2023

⚠️ No Changeset found

Latest commit: c7908a6

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@vanpho93 vanpho93 force-pushed the fix/promotion-can-not-disabled branch 2 times, most recently from 07008ae to fea93c7 Compare January 17, 2023 01:51
Signed-off-by: vanpho93 <vanpho02@gmail.com>
@vanpho93 vanpho93 force-pushed the fix/promotion-can-not-disabled branch from fea93c7 to c7908a6 Compare January 17, 2023 02:44
@brent-hoover brent-hoover merged commit 5f1ea9f into feat/promotions Jan 17, 2023
@brent-hoover brent-hoover deleted the fix/promotion-can-not-disabled branch January 17, 2023 17:22
vanpho93 pushed a commit that referenced this pull request Apr 24, 2023
…disabled

fix: promotion disabled but still can appliable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants