Skip to content

Conversation

ChrisPulman
Copy link
Member

@ChrisPulman ChrisPulman commented Oct 7, 2025

… when running on Windows

What kind of change does this PR introduce?

fix for #4170

What is the current behavior?

#4170

What is the new behavior?

Refactored target framework definitions in Directory.Build.props to improve cross-platform support for Maui and test projects. Updated ReactiveUI.Testing.csproj to use the correct target frameworks property. These changes ensure more accurate and flexible multi-platform builds.

What might this PR break?

Resolves a previous issue

Please check if the PR fulfills these requirements

  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

Other information:

Cheesebaron and others added 3 commits October 6, 2025 15:56
Refactored target framework definitions in Directory.Build.props to improve cross-platform support for Maui and test projects. Updated ReactiveUI.Testing.csproj to use the correct target frameworks property. These changes ensure more accurate and flexible multi-platform builds.
@glennawatson glennawatson requested a review from Copilot October 7, 2025 07:25
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR refactors target framework definitions in MSBuild property files to improve cross-platform support for MAUI and testing projects. The changes address issue #4171 by fixing target framework property usage and ensuring proper platform-specific framework resolution.

  • Updates ReactiveUI.Testing.csproj to use the correct target frameworks property
  • Refactors MAUI target framework definitions to properly handle Windows-specific targets
  • Fixes target framework concatenation to avoid overwriting existing values on Windows

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

File Description
src/ReactiveUI.Testing/ReactiveUI.Testing.csproj Changed target frameworks property from ReactiveUIFinalModernTargetFrameworks to ReactiveUIFinalTargetFrameworks
src/Directory.Build.props Refactored MAUI test targets and modern target frameworks to properly handle Windows-specific builds and avoid overwriting existing values

Copy link

codecov bot commented Oct 7, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 34.24%. Comparing base (c339577) to head (7ac638f).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4174      +/-   ##
==========================================
- Coverage   35.25%   34.24%   -1.01%     
==========================================
  Files         140      144       +4     
  Lines        6039     6234     +195     
  Branches      890      926      +36     
==========================================
+ Hits         2129     2135       +6     
- Misses       3746     3932     +186     
- Partials      164      167       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@Cheesebaron
Copy link
Contributor

These are the TFMs on Reactive.Testing now:

image

Not sure if the platform specific ones are needed for this package?

glennawatson and others added 3 commits October 10, 2025 01:24
Introduces a new ReactiveUITestingTargets property to include netstandard2.0, modern .NET targets, and additional Windows-specific frameworks for testing. Updates the ReactiveUI.Testing project to use these targets. Also updates API approval files to reflect changes in target framework attributes.
@ChrisPulman
Copy link
Member Author

image These are now the targets, as per previous versions with net10.0 added

@glennawatson glennawatson merged commit 8605872 into main Oct 9, 2025
5 of 6 checks passed
@glennawatson glennawatson deleted the CP_4171 branch October 9, 2025 21:49
@Cheesebaron
Copy link
Contributor

Thank you so much @ChrisPulman :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants