Skip to content

Conversation

Taritsyn
Copy link
Contributor

Yesterday I released a final version of the JavaScript Engine Switcher 3.0.0. This PR contains a simple upgrade of the JavaScript Engine Switcher's packages, and removing unnecessary dependency (System.Runtime.InteropServices.RuntimeInformation) from the React.Sample.Mvc4 project.

@Taritsyn
Copy link
Contributor Author

Looks like the AppVeyor broke down due to a NU5125 warning. This warning must either be ignored or fixed by replacing in csproj-project files the PackageLicenseUrl elements by the PackageLicenseFile elements (about how to do it described in the “NuGet Error NU5030” article).

@dustinsoftware
Copy link
Member

AdvancedStringBuilder is such a small NuGet package, can its contents be copied straight into JavaScriptEngineSwitcher.Core? If it needs to be separate that is fine, just wondering if we can save a bit of overhead copying around additional dependency DLLs.

(I fixed the Appveyor build)

@Taritsyn
Copy link
Contributor Author

Hello, Dustin!

I specifically extracted this library from the source code of my projects (Bundle Transformer, JavaScript Engine Switcher, MSIE JavaScript Engine, LibSass Host and WebMarkupMin (will use in the next release)) so that they can share the pool of string builders. Microsoft.Extensions.ObjectPool and old versions of the System.Buffers also small libraries, but it does not prevent to use them as dependencies in a large number of projects.

In addition, I plan to further develop this library by adding new extensions for the string builder.

@dustinsoftware
Copy link
Member

Seems reasonable to me, although I don't know that we'll see a measurable difference when executing Javascript server-side when using pooled string builders vs something simpler like ThreadLocal<StringBuilder>.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants