Sync with reactjs.org @ fb382ccb #55
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Link each mention of a React API in rendering-elements.md to the reference docs. On this page replace every static occurrence of `ReactDOM.render()` by link to the reference docs [`ReactDOM.render()`](/docs/react-dom.html#render) Is this in the right direction @sophiebits ? 🤔 ref #2630
…Mode (#2810) This landed in 16.13 via facebook/react#17942
`<renderer>.update()` doesn't return anything
Think of "myriad" as a number. You wouldn't say "a nine of things", you would say "nine things".
1- Added getDerivedStateFromError lifecycle method to "Do Hooks cover all use cases for classes?" 2- Added getSnapshotBeforeUpdate lifecycle method to "How do lifecycle methods correspond to Hooks?"
* added stackblitz to playground * modified link of Stackblitz I changed the link based on comment from @EricSimons
This reverts commit 869c740.
adding next section URL path at the end in order to ease readers follow steps
adding the next section path at the end.
Clarifying a useState sentence
* Fix typo in hooks-faq.md * Update hooks-faq.md * Update hooks-faq.md Co-authored-by: Sophie Alpert <git@sophiebits.com> Co-authored-by: Sunil Pai <threepointone@oculus.com>
- correcting assertion mistakes
`MySlowList` "lag behind" => `MySlowList` "lags behind"
* Update components docs for functional components * Update components-and-props.md Co-authored-by: Sunil Pai <threepointone@oculus.com>
"You can use in new code" => "You can use them in new code"
Missing code
According to [ProofreadNOW](https://www.proofreadnow.com/blog/bid/101485/If-I-Were-or-If-I-Was-Which-is-Correct), > Guideline: Use were (instead of was) in statements that are contrary to fact.
Co-authored-by: Juan Manuel Rinaudo <juan.rinaudo@jemstep.com> Co-authored-by: Sunil Pai <threepointone@fb.com>
I believe it was meant to be "news story", but I could be misunderstanding something in the context of the paragraph.
* Update legacy lifecycle methods componentWillReceiveProps -> componentDidUpdate * Update legacy lifecycle methods componentWillReceiveProps -> componentDidUpdate * Update higher-order-components.md Co-authored-by: Sunil Pai <threepointone@oculus.com>
* Update README.md (improve usability) Clear up the ambiguous "Running locally" to the anchor link for better usability * Update README.md Co-authored-by: Sunil Pai <threepointone@oculus.com>
* [docs] Add missing evens to docs/events page Added missing `onReset` event to Form Events –– (https://reactjs.org/docs/events.html#form-events) Created Generic Events subsection, and added `onError` & `onLoad` events –– (https://reactjs.org/docs/events.html#generic-events) Based on @sophiebits suggestion in following thread: facebook/react#1718 (comment) * [docs] Add event subsection to #supported-events Added Generic Events subsection under Supported Events (https://reactjs.org/docs/events.html#supported-events)
`react-addons-css-transition-group` moved to `react-transition-group`
Change React.createRef() to useRef(null)
This reverts commit 87b4a4f.
I believe this was just from a copy/paste from the JSX example
Added some clarity.
reactjs-translation-bot
requested review from
balazsorban44,
gergely-nagy and
punkah
|
Deploy preview for react-docs-hu ready! Built with commit f6b8495 |
balazsorban44
approved these changes
Mar 9, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR was automatically generated.
Merge changes from reactjs.org at fb382cc
The following files have conflicts and may need new translations:
Please fix the conflicts by pushing new commits to this pull request, either by editing the files directly on GitHub or by checking out this branch.
DO NOT SQUASH MERGE THIS PULL REQUEST!
Doing so will "erase" the commits from master and cause them to show up as conflicts the next time we merge.