React-PropTypes-to-prop-types: ignore migrated named import #188
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes
React-PropTypes-to-prop-types
codemod transforming already migrated named imports incorrectly.These:
Were incorrectly transformed into this:
This PR adds a check to transform only nodes importing from
react
, thus ignoring those importing fromprop-types
.Previously this codemod would basically assume already migrated stuff to use default export:
Also adds tests for both cases.
Fixes #187