Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign. #238

Closed
mic159 opened this issue Oct 4, 2016 · 2 comments

Comments

@mic159
Copy link

mic159 commented Oct 4, 2016

Summary:

When installing react-modal with NPM, i get this warning:

npm WARN deprecated lodash.assign@4.2.0: This package is deprecated. Use Object.assign.

Steps to reproduce:

Using NodeJS 6.x: npm install react-modal

Expected behavior:

I would expect no deprecated dependencies on the latest version.

I assume you want it for a pollyfill. I think there are smaller ones out there that are not deprecated, eg: https://www.npmjs.com/package/object-assign

Additional notes:

Looks like lodash.assign inflates the number of dependencies quite a bit too, it would be good to remove!

├─┬ react-modal@1.4.0 
│ ├── element-class@0.2.2 
│ ├── exenv@1.2.0 
│ └─┬ lodash.assign@3.2.0 
│   ├─┬ lodash._baseassign@3.2.0 
│   │ └── lodash._basecopy@3.0.1 
│   ├─┬ lodash._createassigner@3.1.1 
│   │ ├── lodash._bindcallback@3.0.1 
│   │ ├── lodash._isiterateecall@3.0.9 
│   │ └── lodash.restparam@3.6.1 
│   └─┬ lodash.keys@3.1.2 
│     ├── lodash._getnative@3.9.1 
│     ├── lodash.isarguments@3.1.0 
│     └── lodash.isarray@3.0.4
@diasbruno
Copy link
Collaborator

@rfreitas can you look at this one?

@rfreitas
Copy link

yes, PR been added

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants