v3 don't respect `closeTimeoutMS` on unmount anymore

[Kerumen]

Summary:

Before the React 16 compatibility, we were able to unmount the modal with an animation. It's not possible anymore with the v3.

Steps to reproduce:

1. Add a <Modal /> with closeTimeoutMS={200}
2. Tweak the CSS to display an open and a close animation
3. Mount/unmount the modal

Expected behavior:

The Modal should unmount with an animation.

Link to example of issue:

React 15 and v2: https://codesandbox.io/s/7k63p8lk81 (working)
React 16 and v3: https://codesandbox.io/s/mml6ql88py (not working)

[diasbruno]

Hi @Kerumen, prefer to using isOpen instead of conditional render for modal for now. Need to check when modal is forcible unmounted case.

[Kerumen]

Yes I know. In my case I can't really use isOpen.
And as it used to work, I report this as a regression. :)

[diasbruno]

On src/components/Modal.js there is a setTimeout. Can you dig in a little bit (if you have time)?

[Kerumen]

I tried but no luck. Event with the line commented out the modal seems to unmount instantly.
Maybe this is a change on how React handle willUnmount?

[diasbruno]

Possibly. I'll try something this evening.

[TeamChad]

Hey @diasbruno. Is there any movement on this bug? We are really keen to upgrade our project to React 16 and this is the only issue holding us up :-) We are keen to keep using this great library!

[diasbruno]

@TeamChad Can you do some debugging on this issue? I didn't have time yet to have look at this one (sorry), but I can give some help...One place to look at is the documentation of createPortal.

[diasbruno]

Still didn't find a solution for this issue. We can start a discussion about "why using conditional render for a modal?". Just to get some information/use case for this. cc @TeamChad @Kerumen.

[chriswetterman]

@Kerumen If you change your rendering of the modal to what's below this will solve the issue in your "not working" codesandbox.io link. I had used conditional rendering and needed to make this change after updating React.

    const { modal } = this.state;
    return (
      <div>
        <button onClick={() => this.toggleModal()}>
          Open Example modal
        </button>
        <Modal
          closeTimeoutMS={200}
          isOpen={this.state.modal}
          contentLabel="modal"
          onRequestClose={() => this.toggleModal()}
        >
          <h2>Add modal content here</h2>
        </Modal>
      </div>
    );
  }

[hoodwink73]

Hello folks

I did some debugging. Finally!

Here's what I found. React 16 does not provide any control over unmounting the portal. The portal unmounts whenever the parent unmounts.

facebook/react#10143 (comment) – this issue clarifies that

The issue further points out that the ability to control the unmounting of portal with unstable_renderIntoContainer API(React 15) was never a feature. And it introduced problems for orphaned portal subtrees during their subsequent update cycles.

So, henceforth we will not be able to control the unmounting of the portal using the createPortal API.

Now lets take a look at React Modal code. I will present what I understand after the debugging.

react-modal/src/components/Modal.js

Lines 150 to 169 in 4377cc8

	componentWillUnmount() {
	if (!canUseDOM || !this.node || !this.portal) return;
	const state = this.portal.state;
	const now = Date.now();
	const closesAt =
	state.isOpen &&
	this.props.closeTimeoutMS &&
	(state.closesAt || now + this.props.closeTimeoutMS);
	if (closesAt) {
	if (!state.beforeClose) {
	this.portal.closeWithTimeout();
	}
	setTimeout(this.removePortal, closesAt - now);
	} else {
	this.removePortal();
	}
	}

In case of React 15, unmounting the parent will set up a timer. And after the timer elapses, removePortal is invoked. And it unmounts the portal using ReactDOM.unmountComponentAtNode. And this triggers the portal’s componentWillUnmount.

react-modal/src/components/Modal.js

Lines 171 to 175 in 4377cc8

	removePortal = () => {
	!isReact16 && ReactDOM.unmountComponentAtNode(this.node);
	const parent = getParentElement(this.props.parentSelector);
	parent.removeChild(this.node);
	};

In React 15, the fading out animation of the portal takes place between these componentWillUnmount of the parent(of portal) and removePortal, during which the portal very much stays in the DOM.

In React 16, we lose the ability to schedule the unmounting of the portal itself. Hence we cannot perform any animation.

[jcrben]

Odd. I'm able to fade out without any issue. Running:

• "react-modal": "^3.6.1"
• "react-dom": "^16.4.2"
• "react": "^16.4.2"

and basically just using http://reactcommunity.org/react-modal/styles/transitions.html

[befront]

Somebody find the solution for closing animation?