[added] ability to change default 'ReactModalPortal' class #208
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes proposed:
portalClassName
prop to change the ReactModalPortal class.Upgrade Path (for changed or removed APIs):Acceptance Checklist:
CONTRIBUTING.md
.If the commit message has [changed] or [removed], there is an upgrade path above.Thanks for this project!
What do you think about adding this?
I think this is useful because:
.CustomModal > (.CustomModal-content + .CustomModal-overlay)
and not like.ReactModalPortal > (.CustomModal-content + .CustomModal-overlay)
.Few questions on my side: