Skip to content

[added] Make modal portal have the dialog role #223

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 21, 2016
Merged

[added] Make modal portal have the dialog role #223

merged 1 commit into from
Sep 21, 2016

Conversation

claydiffrient
Copy link
Contributor

Fixes #212.

Changes proposed:

  • Make the dialog role be present on the modal content.

Acceptance Checklist:

  • All commits have been squashed to one.
  • The commit message follows the guidelines in CONTRIBUTING.md.
  • Documentation (README.md) and examples have been updated as needed.
  • If this is a code change, a spec testing the functionality has been added.
  • If the commit message has [changed] or [removed], there is an upgrade path above.

@claydiffrient claydiffrient merged commit 2e806c7 into master Sep 21, 2016
@claydiffrient claydiffrient deleted the dialog-role branch September 21, 2016 16:54
This was referenced Oct 3, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@claydiffrient