[fixed] Don't set aria-modal attribute when running on apple's Webkit. #615
+22
−18
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonascimento
force-pushed
the
fix/voice-over-fails
branch
from
287e79f to
e12d6ce
Compare
src/components/ModalPortal.js
Outdated
| const { className, overlayClassName, defaultStyles } = this.props; | ||
| const contentStyles = className ? {} : defaultStyles.content; | ||
| const overlayStyles = overlayClassName ? {} : defaultStyles.overlay; | ||
| const ariaModal = (navigator.userAgent.match(/iPhone/i)) || (navigator.userAgent.match(/iPad/i)) |
There was a problem hiding this comment.
Please verify for "Mac OS" too, issue appear though all apple devices that use VoiceOver screen reader
diasbruno
changed the title
leonascimento
force-pushed
the
fix/voice-over-fails
branch
6 times, most recently
from
839e96e to
184522f
Compare
leonascimento
force-pushed
the
fix/voice-over-fails
branch
from
184522f to
bdf41a9
Compare
|
@diasbruno @MaksimKniazeu I did an update on this pull request. Can you make the code review? |
|
Uh... I don't maintain this library. |
|
@markerikson sorry man, I wrote wrong. |
diasbruno
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #611.
-This merge request should prevent that the VoiceOver fails.
Changes proposed:
-Define false to
aria-modalwhen is webkit.Upgrade Path:
-Change the value when is webkit.
-
isSafariDesktoptransforming this function in a helper function to use on others places.Acceptance Checklist:
CONTRIBUTING.md.