You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I'm working on an app where we need to be able to manually unmount specific components when a modal is closed. This PR adds a searchSelector argument to ReactRailsUJS.mountComponents and ReactRailsUJS.unmountComponents which lets you target specific elements.
This is similar to #91. This functionality has been listed as a goal for 1.0 (#133) but the author of #91 hasn't responded in two months so I opened this PR.
Thank you for your pull request and welcome to our community. We require contributors to sign our Contributor License Agreement, and we don't seem to have you on file. In order for us to review and merge your code, please sign up at https://code.facebook.com/cla - and if you have received this in error or have any questions, please drop us a line at cla@fb.com. Thanks!
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I'm working on an app where we need to be able to manually unmount specific components when a modal is closed. This PR adds a
searchSelectorargument toReactRailsUJS.mountComponentsandReactRailsUJS.unmountComponentswhich lets you target specific elements.This is similar to #91. This functionality has been listed as a goal for 1.0 (#133) but the author of #91 hasn't responded in two months so I opened this PR.