Make sure to only mount components once per DOM node #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I've been encountering an issue where on initial page load the event handler for `page:change` was getting fired twice, causing the React components to be mounted twice, which caused all sorts of trouble. This introduces a simple map of DOM nodes to booleans that acts as a guard against nodes getting components mounted to them more than once.
|
React.renderComponent should be idempotent though… |
|
So is the issue here actually that trying to render an identical component to a node twice isn't working properly for this version of React? |
|
I don't know what the issue is but the fix proposed here sounds off to me. |
|
@glittershark how about we start with a repro case? |
|
I think this is the same issue as #69 |
|
Just merged #69. Can you see if this is still occurring for you @glittershark? |
|
@zpao that does it! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've been encountering an issue where on initial page load the event
handler for
page:changewas getting fired twice, causing the Reactcomponents to be mounted twice, which caused all sorts of trouble. This
introduces a simple map of DOM nodes to booleans that acts as a guard
against nodes getting components mounted to them more than once.