Skip to content

Make sure to only mount components once per DOM node #79

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 1 commit into from
Closed

Make sure to only mount components once per DOM node #79

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 10 additions & 1 deletion lib/assets/javascripts/react_ujs.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,6 +6,10 @@
// jQuery is optional. Use it to support legacy browsers.
var $ = (typeof jQuery !== 'undefined') && jQuery;

// Maps DOM nodes to booleans specifying whether or not those
// nodes already have a component mounted in them
var mounted = {};

var findReactDOMNodes = function() {
var SELECTOR = '[' + CLASS_NAME_ATTR + ']';
if ($) {
Expand All @@ -25,14 +29,19 @@
var constructor = window[className] || eval.call(window, className);
var propsJson = node.getAttribute(PROPS_ATTR);
var props = propsJson && JSON.parse(propsJson);
React.renderComponent(constructor(props), node);

if (!mounted[node]) {
React.renderComponent(constructor(props), node);
mounted[node] = true;
}
}
};

var unmountReactComponents = function() {
var nodes = findReactDOMNodes();
for (var i = 0; i < nodes.length; ++i) {
React.unmountComponentAtNode(nodes[i]);
delete mounted[node];
}
};

Expand Down