Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix deprecation warnings for react >= 15.5.0 #663

Merged
merged 1 commit into from Apr 9, 2017

Conversation

Calyhre
Copy link
Contributor

@Calyhre Calyhre commented Apr 8, 2017

Migrate React.PropTypes to PropTypes from the prop-types package, regarding the latest react version -> https://facebook.github.io/react/blog/2017/04/07/react-v15.5.0.html#migrating-from-react.proptypes

@jimbolla
Copy link
Contributor

jimbolla commented Apr 8, 2017

Does this work if someone is still targeting React 14?

@wojtekmaj
Copy link

It should. PropTypes were not wildly modified since then.

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2017

It should work. But I'm not sure if putting it in dependencies would be better.

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2017

Yes, lets change this to use dependencies instead.

@Calyhre
Copy link
Contributor Author

Calyhre commented Apr 8, 2017

Ok :) I moved it from devDependencies to dependencies, and drop the line for peers.

@gaearon
Copy link
Contributor

gaearon commented Apr 8, 2017

We probably don't need Yarn lock? Seems unrelated to this PR.

@Calyhre
Copy link
Contributor Author

Calyhre commented Apr 8, 2017

👍 yarn.lock modifications removed

@timdorr
Copy link
Member

timdorr commented Apr 9, 2017

Yes, you do. yarn.lock files are updated with every PR that modifies the dependencies. It's the same for other systems that use lock files (e.g., rubygems)

@timdorr
Copy link
Member

timdorr commented Apr 9, 2017

Thanks, @Calyhre. I've got some follow-on fixes for the tests and to put the lock file back. I'll add those after I merge this in. Thanks!

@timdorr timdorr merged commit cdf1369 into reduxjs:master Apr 9, 2017
@gaearon
Copy link
Contributor

gaearon commented Apr 9, 2017

Yes, you do. yarn.lock files are updated with every PR that modifies the dependencies

Oops, pardon the brainfart. I don't really understand why I said that 😛

@gaearon
Copy link
Contributor

gaearon commented Apr 9, 2017

@Calyhre Would you like to also send a PR to backport this to 4.x?

@timdorr
Copy link
Member

timdorr commented Apr 9, 2017

Just pushed out 5.0.4 with this. Thanks!

@Calyhre Calyhre deleted the fix/react-warnings branch April 9, 2017 15:06
@lama-pacos
Copy link

old react version will warning
…………

@gaearon
Copy link
Contributor

gaearon commented Apr 12, 2017

Yes, we’re discussing this in #669.

@gaearon
Copy link
Contributor

gaearon commented Apr 12, 2017

I released react@0.14.9 and react-dom@0.14.9, they won’t have the warning.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants