Patch the DOM to fix Google Translate #1148
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for reactjs failed. Built with commit d72a2c7 https://app.netlify.com/sites/reactjs/deploys/5b888aa682d3f124a5d5bd7e |
|
cc @KyleAMathews dunno if you get questions about this but you might find it useful.. just don't make it a default. |
|
Yeah, there's been one issue about it gatsbyjs/gatsby#6300 Pointed people there here. |
sebmarkbage
approved these changes
Aug 31, 2018
|
I think gatsbyjs/gatsby#6300 is different and is about #467. We need to fix it too. Can you help? I’m not sure where to look. |
|
@gaearon yeah — I'm pretty sure we could support it when some other tool mutates the URL assuming the patterns are consistent. I'm tied up currently getting Gatsby v2 out but I'd be happy to support someone who wants to work on it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think it's unacceptable to have Google Translate broken on our website, especially considering we don't yet offer any official translations. See facebook/react#12460.
So I'm adding a hack described in facebook/react#11538 (comment). I'm not too worried about performance since this is mostly a static website anyway.
Before the hack:
After the hack: