Add more functions to CompressedResource #123
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chocolatkey
changed the title
mickael-menu
approved these changes
Oct 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the
CompressedResourceinterface was added, to possibly stream resources in their original compressed format, to avoid having to decompress responses server-side before sending to the client.This PR adds the
ReadCompressedfunction to that interface, so that resources are not just streamed, but can also be read as a[]bytein compressed form.It also now adds GZIP versions of the stream/read functions directly in the toolkit, to make sending responses to clients that do not support deflate possible. This is particularly useful when placing the server behind a CDN like Cloudflare, that does not send
deflatein itsaccept-encodingheader.