ES2015+ refactoring and project restructuring #69
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jccr
force-pushed
the
feature/es-refactor
branch
from
991ddcd
to
5f26189
Compare
jccr
force-pushed
the
feature/es-refactor
branch
from
5f26189
to
57eefc0
Compare
added 18 commits
March 15, 2018 13:52
…d bundle output. The created bundle is ready, with zero configuration, to be a dependency through NPM
* Removed Readium build tool scripts - Will be migrated over to readium-shared-js * Removed RequireJS as a bundler and its config files * Added Rollup.js as a bundler - It's great for producing libraries! * PEG.js changed to generate in CommonJS module format * Yarn specifics dropped - It's better to just use one package manager * Removal of package.cson - The new package.json is simplified so it makes less sense to keep it * Added ESLint as a linter - Adopting the popular Airbnb style * Prepare codebase for ES2015+ refactoring
TODO: There's a bunch of "internal" public/exported/accessible functions that are not part of the original public API that need to be encapsulated again. The tests need to get at them still, and I really like the simplicity with `export * from 'module'`. I don't want to have to register forwarding functions in the index like before.
There's no docs or compatible doc comments around it seems...
jccr
force-pushed
the
feature/es-refactor
branch
from
53aa34b
to
1130fb6
Compare
jccr
added a commit
to evidentpoint/readium-cfi-js
that referenced
this pull request
Aug 9, 2019
ES2015+ refactoring and project restructuring
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Goal: Modernization
prettier --write --print-width 100 --single-quote --trailing-comma all --arrow-parens always [file], then used WebStorm to further customize the reformatting. For that I added the .idea files so it's reproducible and for convenience.This pull request is a Work In Progress
Related issue(s) and/or pull request(s)
readium/readium-js-viewer#373
Testing
Test suite mostly succeeds except with two cases due to a function reference issue with
jasmine.spyOnWhat needs to be done before merging
What needs to be done after merging