fixes boolean settings save mismatch #626

readium · Jun 8, 2017 · 51b4e61 · 51b4e61
1 parent 8d46014
commit 51b4e61
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/src/js/EpubReader.js b/src/js/EpubReader.js
@@ -1071,7 +1071,7 @@ BookmarkData){
             {
                 if (SettingsDialog.defaultSettings.hasOwnProperty(prop))
                 {
-                    if (!settings.reader.hasOwnProperty(prop) || !settings.reader[prop]) {
+                    if (!settings.reader.hasOwnProperty(prop) || (typeof settings.reader[prop] == "undefined")) {
                         settings.reader[prop] = SettingsDialog.defaultSettings[prop];
                     }
                 }

diff --git a/src/js/ReaderSettingsDialog.js b/src/js/ReaderSettingsDialog.js
@@ -143,7 +143,7 @@ define(['./ModuleConfig', 'hgn!readium_js_viewer_html_templates/settings-dialog.
                 readerSettings = readerSettings || defaultSettings;
                 for (prop in defaultSettings)
                 {
-                    if (defaultSettings.hasOwnProperty(prop) && !readerSettings.hasOwnProperty(prop) && !readerSettings[prop])
+                    if (defaultSettings.hasOwnProperty(prop) && (!readerSettings.hasOwnProperty(prop) || (typeof readerSettings[prop] == "undefined")))
                     {
                         readerSettings[prop] = defaultSettings[prop];
                     }