Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

api: ui config endpoint #103

Closed
mvidalgarcia opened this issue Jun 9, 2020 · 0 comments · Fixed by #108, reanahub/reana-server#259, reanahub/reana-commons#194 or reanahub/reana#343
Closed

api: ui config endpoint #103

mvidalgarcia opened this issue Jun 9, 2020 · 0 comments · Fixed by #108, reanahub/reana-server#259, reanahub/reana-commons#194 or reanahub/reana#343
Assignees
@mvidalgarcia
Labels
deployment/helm system/api

Comments

@mvidalgarcia
Copy link
Member

Stems from reanahub/reana-server#254 (comment).

Current behavior

  • Configuration information that is consumed by the UI is scattered between /me and config.js. e.g the recently added announcements, the Mattermost URL, etc.
  • This forces us to rebuild the UI image whenever we want to change something in config.js.

Expected behavior

  • To have a /config endpoint to serve this information from a single point.
  • Add these configurations to config.py reading from env vars.
  • Add them to helm values.yaml or configmaps (not sure what's better) to be easily configurable.
@mvidalgarcia mvidalgarcia self-assigned this Jun 22, 2020
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Jun 23, 2020
@mvidalgarcia
config: fetch from server and move to redux state
815d8b0 
closes reanahub#103
@mvidalgarcia mvidalgarcia mentioned this issue Jun 23, 2020
Merged
mvidalgarcia added a commit to mvidalgarcia/reana-server that referenced this issue Jun 23, 2020
@mvidalgarcia
rest: add ui config endpoint
f588970 
closes reanahub/reana-ui#103
@mvidalgarcia mvidalgarcia mentioned this issue Jun 23, 2020
Merged
mvidalgarcia added a commit to mvidalgarcia/reana-commons that referenced this issue Jun 23, 2020
@mvidalgarcia
openapi: add config endpoint
065570f 
closes reanahub/reana-ui#103
@mvidalgarcia mvidalgarcia mentioned this issue Jun 23, 2020
Merged
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 23, 2020
@mvidalgarcia
helm: add reana-ui config env vars
0869723 
closes reanahub/reana-ui#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 23, 2020
@mvidalgarcia
helm: add reana-ui config env vars
f5e295a 
closes reanahub/reana-ui#103
@mvidalgarcia mvidalgarcia mentioned this issue Jun 23, 2020
Merged
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Jun 24, 2020
@mvidalgarcia
config: fetch from server and move to redux state
2d01483 
closes reanahub#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 24, 2020
@mvidalgarcia
helm: add reana-ui configmap
2c7b6c1 
closes reanahub/reana-ui#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 24, 2020
@mvidalgarcia
helm: add reana-ui configmap
14a7c53 
closes reanahub/reana-ui#103
addresses reanahub#277
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Jun 25, 2020
@mvidalgarcia
config: fetch from server and move to redux state
f6d1e5d 
closes reanahub#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 25, 2020
@mvidalgarcia
helm: add reana-ui configmap
2c721ff 
closes reanahub/reana-ui#103
addresses reanahub#277
mvidalgarcia added a commit to mvidalgarcia/reana-server that referenced this issue Jun 25, 2020
@mvidalgarcia
rest: add ui config endpoint
f38434d 
closes reanahub/reana-ui#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 25, 2020
@mvidalgarcia
helm: add reana-ui configmap
3cc0237 
closes reanahub/reana-ui#103
addresses reanahub#277
@mvidalgarcia mvidalgarcia reopened this Jun 25, 2020
mvidalgarcia added a commit to mvidalgarcia/reana-ui that referenced this issue Jun 26, 2020
@mvidalgarcia
config: fetch from server and move to redux state
a969015 
closes reanahub#103
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 26, 2020
@mvidalgarcia
helm: add reana-ui configmap
945ecf8 
closes reanahub/reana-ui#103
addresses reanahub#277
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 26, 2020
@mvidalgarcia
helm: add reana-ui configmap
41fcfb1 
closes reanahub/reana-ui#103
addresses reanahub#277
mvidalgarcia added a commit to mvidalgarcia/reana that referenced this issue Jun 26, 2020
@mvidalgarcia
helm: add reana-ui configmap
1643b38 
closes reanahub/reana-ui#103
addresses reanahub#277
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@mvidalgarcia mvidalgarcia

Labels
deployment/helm system/api
Projects
None yet
Milestone
No milestone
1 participant
@mvidalgarcia