-
Notifications
You must be signed in to change notification settings - Fork 54
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ease extension of REANA configuration #277
Comments
mvidalgarcia
added a commit
to mvidalgarcia/reana-commons
that referenced
this issue
Jun 24, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana-server
that referenced
this issue
Jun 24, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 24, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
mvidalgarcia
added a commit
to mvidalgarcia/reana-commons
that referenced
this issue
Jun 25, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana-commons
that referenced
this issue
Jun 25, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 25, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
mvidalgarcia
added a commit
to mvidalgarcia/reana-server
that referenced
this issue
Jun 25, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 25, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
mvidalgarcia
added a commit
to mvidalgarcia/reana-server
that referenced
this issue
Jun 25, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana-server
that referenced
this issue
Jun 26, 2020
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 26, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 26, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
mvidalgarcia
added a commit
to mvidalgarcia/reana
that referenced
this issue
Jun 26, 2020
closes reanahub/reana-ui#103 addresses reanahub#277
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Background
Currently, it is only possible to add new configuration through environment variables. For example, the
REANA_MAX_CONCURRENT_BATCH_WORKFLOWS
is a configuration read by REANA-Commons and used eventually in REANA-Server, this is a simple case which doesn't show too much indirection, it is an environment variable passed to an infrastructure pod.Problem
When the configuration needs to be passed to a runtime pod, let's say REANA-Job-Controller, the process becomes more tedious. Let's take the example of
REANA_STORAGE_BACKEND
. Again this is an environment variable read by REANA-Commons, which at some point needs to be used by RJC to decide whether jobs should use shared storage viahostpath
or via network file system. So the chain goes like follows:This is a procedure which is:
(2)
) to just pass the config over, with a chance of making mistakes in the middle(2)
.Possible solutions
(1) Central configuration file with all variables: This configuration file is still being loaded by REANA-Commons, so we have only one part in the code where the configuration is loaded, but then all components see all config.
(2) Split configuration per "groups of components": one configuration file for infrastructure components, another configuration file for runtime pods and a global one (this could explode in complexity if more groups are to be created). A quick and verbose prototype:
In either (1) or (2), new
configmap
(s) would be added to the Helm chart and it/they would be paramtrised fromvalues.yaml
.The text was updated successfully, but these errors were encountered: