cli: fix git-upgrade-shared-modules

[mvidalgarcia]

closes #412

[alintulu]

-    "reana-db>=0.8.0a4,<0.9.0",
+    "reana-db>=0.8.0a4,<0.9.0

It seems like the trailing ", is missing. The regex .* matches any character (except for line terminator) which means the ", gets replaced as well. A possible fix could perhaps be .*(?=",) which matches any character except for the line terminator however doesn't count ",?

[mvidalgarcia]

Omg I'm blind, thanks for spotting this!

[alintulu]

To be fair I starred a long time at the git diff thinking.. but how do they differ?

[mvidalgarcia]

I've tried .*(?=",) and even matching properly what we want, it seems it doesn't work with sed, it does not perform any substitution.. For instance, in r-server, running sed -i.bk '52s/>=.*,<.*(?=",)/>=0.8.0a4,<0.9.0/' setup.py && [ -e setup.py.bk ] && rm setup.py.bk doesn't do any change..
I went for a more pragmatic way, let me know what you think

[alintulu]

Apparently you can also use [^",] to exclude ",. Seems to work with sed. I just tried sed 's/>=.*,<.*[^",]/test/' file and it worked. But I don't see anything wrong with your pragmatic way as well!

[alintulu]

$ cat file
>=0.8.0a4,<0.9.0",

$ sed 's/>=.*,<.*[^",]/test/' file
test",

[mvidalgarcia]

Nice! I like that one. I've got a lot to learn about regex..
Updated.