helm: make quota accounting configurable

[mvidalgarcia]

closes #562

[codecov-commenter]

Codecov Report

Merging #566 (1e6f9fc) into master (381bd50) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #566   +/-   ##
=======================================
  Coverage   26.00%   26.00%           
=======================================
  Files          17       17           
  Lines        1546     1546           
=======================================
  Hits          402      402           
  Misses       1144     1144           

[audrium]

Disabling quota calculation works well!

Few minor remarks:

• Right now it's possible to either disable quota calculations at all, or to do it after every workflow run + cronjob. We are missing a setting to do it only via cronjob.
• quota.termination_update_policy configuration name is not really clear, since it's not a policy, but more like a resource list for quota calculation (which is used also in cronjob, so not only termination?)

[mvidalgarcia]

Thanks for the review! I enriched the logic a little bit to be able to have more configurations.

• Right now it's possible to either disable quota calculations at all, or to do it after every workflow run + cronjob. We are missing a setting to do it only via cronjob.

I made it more fine-grained to support enabling only the cronjob or only the workflow terminantion logic.
One now can:

• Disable all the quota functionality altogether by switching the enabled flag to false.
• When quota is enabled: true:
  • Disable only the workflow termination accounting by not setting termination_update_policy.
  • Disable only the cronjobs by not setting the disk_update crontab.

• quota.termination_update_policy configuration name is not really clear, since it's not a policy, but more like a resource list for quota calculation (which is used also in cronjob, so not only termination?)

The name is based on the REANA_WORKFLOW_TERMINATION_QUOTA_UPDATE_POLICY env var, and now it only refers to the actual workflow termination updater (no cronjob).
Do you have another name in mind? I guess that if we change it we should also change the env var name in reana-db?

[audrium]

Tested carefully, everything works nicely!

• Left one minor comment for the readme file

• The name is based on the REANA_WORKFLOW_TERMINATION_QUOTA_UPDATE_POLICY env var, and now it only refers to the actual workflow termination updater (no cronjob).

  Make sense and looks good to me since it's now only related with workflow termination

[audrium]

Minor: perhaps we should also indicate that workflow termination accounting can be disabled by not setting termination_update_policy. We could add something similar as in quota.disk_update: Leave it empty to deactivate workflow termination accounting , WDYT?

[mvidalgarcia]

Yes, it makes total sense, adding it 👍