Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(statics): handle 404 errors for static files #1006

Merged
merged 1 commit into from Jan 20, 2022

Conversation

frascuchon
Copy link
Member

This PR allows refresh pages in rubrix app, since the default behaviour is a 404 response message.

The starlette.get_response behind has changed since some release and now, we must catch HTTPException too.

This fix will allow open datasets in another tab, for example.

@frascuchon frascuchon added type: bug Indicates an unexpected problem or unintended behavior app labels Jan 20, 2022
@frascuchon frascuchon added this to In progress in Release via automation Jan 20, 2022
@frascuchon frascuchon force-pushed the hotfixes/allow-url-refresh-app-page branch from 7b26f43 to 8008684 Compare January 20, 2022 11:20
@codecov
Copy link

codecov bot commented Jan 20, 2022

Codecov Report

Merging #1006 (8008684) into master (e6a9425) will decrease coverage by 0.13%.
The diff coverage is 23.07%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1006      +/-   ##
==========================================
- Coverage   95.48%   95.35%   -0.14%     
==========================================
  Files         110      110              
  Lines        4235     4244       +9     
==========================================
+ Hits         4044     4047       +3     
- Misses        191      197       +6     
Flag Coverage Δ
pytest 95.35% <23.07%> (-0.14%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
src/rubrix/server/commons/static_rewrite.py 44.44% <23.07%> (-11.12%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e6a9425...8008684. Read the comment docs.

Release automation moved this from In progress to Review Jan 20, 2022
@frascuchon frascuchon merged commit a77ee01 into master Jan 20, 2022
Release automation moved this from Review to Done Jan 20, 2022
@frascuchon frascuchon deleted the hotfixes/allow-url-refresh-app-page branch January 20, 2022 14:46
@frascuchon frascuchon moved this from Done to Release Ready in Release Jan 20, 2022
frascuchon added a commit that referenced this pull request Jan 20, 2022
@frascuchon frascuchon moved this from Release Ready to Closed in Release Jan 20, 2022
dvsrepo added a commit that referenced this pull request Jan 25, 2022
* 'master' of https://github.com/recognai/rubrix: (28 commits)
  chore(#994): simplify server start (#1014)
  refactor(#945): elasticsearch index configuration per task (#1018)
  docs(#980): Add majorityvote example to weak supervision guide (#1004)
  fix(#1015): manage emojis in Token Classification records (#1016)
  fix(#1010): fix WeakLabels when not providing rules (#1011)
  fix(Breadcrumbs): Copy text function (#1003)
  fix(statics): handle 404 errors for static files (#1006)
  refactor: Rename 'exclude_missing_annotation' argument for WeakLabels.annotation (#1005)
  docs: update video for spacy ner tutorial (#1000)
  fix(#977) Remove redirection when accessing login (#996)
  feat(#951): new uncovered_by_rules records filter (#991)
  feat(#735): add warning when agent but no prediction/annotation is provided (#987)
  fix(#800): limit number of metadata fields (#993)
  docs: improve annotate records section in web app reference (#985)
  fix(#844) Keep header layout when errors occurred in dataset view (#992)
  fix(#974): display the dropdown in the last record of the scroll (#986)
  refactor: compute common aggregations one by one (#990)
  feat(#953): add additional metrics to `LabelModel.score` method (#979)
  refactor(rules): using labeling rules management with vuex store (#878)
  feat(#955): add default for `rules` in WeakLabels (#976)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: bug Indicates an unexpected problem or unintended behavior
Projects
No open projects
Release
Approved Release QA
Development

Successfully merging this pull request may close these issues.

None yet

2 participants