Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use type-safe private-property accessors #1644

Closed
wants to merge 2 commits into from

Conversation

staabm
Copy link
Contributor

@staabm staabm commented Jan 7, 2022

utlitize deprecated-packages/symplify#3860

this PR requires a update of the package-builder lib, which I am an not able todo, as described in #1590 (comment)

@TomasVotruba
Copy link
Member

I've released Symplify 10.0.9 few minutes ago, so you can use new version.

@staabm
Copy link
Contributor Author

staabm commented Jan 8, 2022

I tried updating the dependencies. I don't know wich combination of the requirements will make composer happy..

@TomasVotruba
Copy link
Member

The issue was with stuck upgrade of https://packagist.org/packages/symplify/symfony-php-config
For some reason, packagist does not pick up new released tags and it always have to be done manually. The setup in Github repository is identical with other Symplify packages.

I've just bumped the version in packagist.

@TomasVotruba
Copy link
Member

Cherry picked manually with CS fixes and composer.json tuning in: #1660

@staabm staabm deleted the type-safe-access branch January 11, 2022 15:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants