[Test] Reduce RunTestsInSeparateProcesses usage #3667
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
approved these changes
Apr 23, 2023
| @@ -2,7 +2,7 @@ | |||
|
|
|||
| namespace Rector\Tests\Renaming\Rector\FileWithoutNamespace\PseudoNamespaceToNamespaceRector\Fixture; | |||
|
|
|||
| class Fixture6 | |||
| class PhpunitTestCaseSplit | |||
There was a problem hiding this comment.
Do we need a new phpstan rule which makes sure classes within fixtures are uniquely named?
There was a problem hiding this comment.
probably needed , sometime, phpstan still read previous class "in memory", probably as "analyzed file" cache
|
The error seems only on CI |
|
Let's try use |
This reverts commit af7c37c.
|
it seems using |
|
Let's rename the class fixture to avoid duplicate use by other rule a6f6f85 |
|
Let's rollback |
samsonasik
changed the title
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* [Test] Remove RunTestsInSeparateProcesses usage * [ci-review] Rector Rectify * rename fixture classes * rename fixture * use FileCacheStorage for RenameClassRectorTest * Revert use FileCacheStorage for RenameClassRectorTest This reverts commit af7c37c. * rename class * rename fixture * another rename * rollback RunTestsInSeparateProcesses --------- Co-authored-by: GitHub Action <actions@github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@staabm RunTestsInSeparateProcesses was used to cover error tests which possible due to duplicate file fixture on run tests. This was rolled back tried, rolled back, and re-tried, see https://github.com/rectorphp/rector-src/pulls?q=is%3Apr+RunTestsInSeparateProcesses+is%3Aclosed
Let's try
removereduce to see if now some that no longer needed.