[Testing] Reduce IO on AbstractRectorTestCase::doTestFile() #3670
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@staabm let's see if can resolve random error of tests. |
|
@TomasVotruba I added new method |
|
it's seems not really resolve the random error, but actually should be faster now since no need to re-read the file already read and save to previous variable. |
|
All checks have passed 🎉 @TomasVotruba I am merging it ;) |
samsonasik
added a commit
that referenced
this pull request
May 8, 2023
* [Testing] Reduce IO on AbstractRectorTestCase::doTestFile() * direct call
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
FileSystem::read()already call early, so I added new methodFixtureSplitter::splitFixtureFileContents()for direct already defined content.