[TypeDeclaration] Handle regression multiple params no longer working on AddMethodCallBasedStrictParamTypeRector

[samsonasik]

@internalsystemerror this is I try to cover regression that happen when dealing with infinite loop on PR:

• [TypeDeclaration] Handle infinite loop on array_reverse with index on AddMethodCallBasedStrictParamTypeRector on php8+ feature #3678

which multiple params which one of them is Union Type no longer working now.

[samsonasik]

Call:

$this->phpStanStaticTypeMapper->mapToPhpParserNode($unionType, $typeKind);

On union type narrow bool seems was the source why cause infinite loop

https://github.com/rectorphp/rector-src/pull/3681/files#diff-88741beb0f7f0d97e0197e1e8903ababaacf70ec8c75e4d785367837e9265db9

Let's try...

[samsonasik]

this seems cause error test:

There was 1 failure:

1) Rector\Tests\Php80\Rector\FunctionLike\UnionTypesRector\UnionTypesRectorTest::test with data set #23
Failed on fixture file "narrow_bool_false2.php.inc"
Failed asserting that string matches format description.
--- Expected
+++ Actual
@@ @@
 
 class NarrowBoolFalse2
 {
-    public function go(bool|int $param): bool|int
+    /**
+     * @param bool|int|false $param
+     * @return bool|int|false
+     */
+    public function go($param)

I will check.

[samsonasik]

Let's check that it has bool type before try to apply narrow bool 3199d38

[samsonasik]

skipping re-map on union type is safer, see comment #3681 (comment)

[samsonasik]

@TomasVotruba while this bool type is working 3199d38, is working, I think re-check by

$this->phpStanStaticTypeMapper->mapToPhpParserNode($unionType, $typeKind);

is still dangerous for passing union type in union type mapper, as that kind of usage can be vary in multiple types with same sub, eg: add IntegerRangeType, I am going to just skip when doctype types count is not equal with union type node as this can happen again.

like this :

class SkipNarrowBoolFalseAnotherType
{
    /**
     * @param bool|int|false|int<0, max> $param
     * @return bool|int|false
     */
    public function go($param)
    {
        if (rand(0, 1)) {
            return rand(0, 1) ? true : false;
        }

        return 1;
    }
}

got type again https://3v4l.org/jfN4m

so:

@param skip narrow bool|false|<OtherTypeHere>

will be skipped, see b3ac267

[samsonasik]

All checks have passed 🎉 @TomasVotruba I am merging it ;)

[samsonasik]

@eugeniya-v FYI, bool|false|AnotherType docblock is now just skipped on UnioTypesRector as may cause invalid type again when docblock extended, eg: bool|int|false|int<0, max> that goes to bool|false|int again and may cause infinite loop on no bool type when used on AddMethodCallBasedStrictParamTypeRector, only bool|false that converted to bool that converted

see :

• converted: bool|false to bool: https://getrector.com/demo/341d0db8-911f-498c-932b-c76e633cc6d3
• skipped : bool|false|int https://getrector.com/demo/94d532d6-fb57-4999-b247-1625161e64c8