Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add failing test fixture for ClassPropertyAssignToConstructorPromotionRector #749

Closed
wants to merge 1 commit into from

Conversation

enumag
Copy link
Contributor

@enumag enumag commented Aug 24, 2021

Failing Test for ClassPropertyAssignToConstructorPromotionRector

Based on https://getrector.org/demo/1ec04a84-bde1-6cb0-a397-d7c0f606a738

@samsonasik
Copy link
Member

@enumag I cherry-picked your commit at PR #751

TomasVotruba pushed a commit that referenced this pull request Aug 24, 2021
…orPromotionRector (#751)

* Add failing test fixture for ClassPropertyAssignToConstructorPromotionRector

# Failing Test for ClassPropertyAssignToConstructorPromotionRector

Based on https://getrector.org/demo/1ec04a84-bde1-6cb0-a397-d7c0f606a738

* Closes #749

* naming

* phpstan

* early check is param used before assign

Co-authored-by: Jáchym Toušek <enumag@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants