Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[StaticTypeMapper] Add ParentStaticType support to NameNodeMapper for "parent" return type #765

Merged
merged 1 commit into from
Aug 26, 2021
Merged

[StaticTypeMapper] Add ParentStaticType support to NameNodeMapper for "parent" return type #765

merged 1 commit into from
Aug 26, 2021

Conversation

samsonasik
Copy link
Member

So DowngradeParentTypeDeclarationRector can use PhpDocFromTypeDeclarationDecorator service.

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 5b5b94b into main Aug 26, 2021
@TomasVotruba TomasVotruba deleted the add-parent-stsatic-type-mapper-name-node-mapper branch August 26, 2021 07:48
@samsonasik
Copy link
Member Author

It seems broke the rector scoped rectorphp/rector@870f774

@samsonasik samsonasik mentioned this pull request Aug 26, 2021
Merged
@samsonasik
Copy link
Member Author

I created a PR to fix it #769

@samsonasik samsonasik mentioned this pull request Aug 26, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@samsonasik @TomasVotruba