Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BetterPhpDocParser] Move PhpDocFromTypeDeclarationDecorator from DowngradePhp71 to BetterPhpDocParser #773

Merged
merged 1 commit into from
Aug 26, 2021

Conversation

samsonasik
Copy link
Member

The PhpDocFromTypeDeclarationDecorator is used in some rules in downgrade-php70, downgrade-php71, downgrade-php80.

I think it can be moved to separate namespace: BetterPhpDocParser

@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba
Copy link
Member

Makes sense, thank you

@TomasVotruba TomasVotruba merged commit 5eb2736 into main Aug 26, 2021
@TomasVotruba TomasVotruba deleted the move-phpdoc-from-type branch August 26, 2021 15:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants