Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DeadCode] Skip RecastingRemovalRector on has __set() and __get() #790

Merged
merged 12 commits into from
Aug 30, 2021

Conversation

samsonasik
Copy link
Member

When property is not found on use casted PropertyFetch, it may be setted via __set() or __get(), which should be skipped.

@samsonasik samsonasik force-pushed the skip-recasting-removal branch from 9017535 to 1918495 Compare August 30, 2021 05:31
@samsonasik
Copy link
Member Author

All checks have passed 🎉 @TomasVotruba it is ready for review.

@TomasVotruba TomasVotruba merged commit 5058437 into main Aug 30, 2021
@TomasVotruba TomasVotruba deleted the skip-recasting-removal branch August 30, 2021 08:17
@TomasVotruba
Copy link
Member

Thank you

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants