DX: Report more precise errors in VerifyRectorServiceExistsCompilerPass
#97
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
staabm
commented
May 24, 2021
src/DependencyInjection/CompilerPass/VerifyRectorServiceExistsCompilerPass.php
Outdated
Show resolved
Hide resolved
staabm
commented
May 24, 2021
src/DependencyInjection/CompilerPass/VerifyRectorServiceExistsCompilerPass.php
Show resolved
Hide resolved
staabm
commented
May 24, 2021
staabm
changed the title
VerifyRectorServiceExistsCompilerPassVerifyRectorServiceExistsCompilerPass
src/DependencyInjection/CompilerPass/VerifyRectorServiceExistsCompilerPass.php
Show resolved
Hide resolved
staabm
commented
May 24, 2021
src/DependencyInjection/CompilerPass/VerifyRectorServiceExistsCompilerPass.php
Outdated
Show resolved
Hide resolved
staabm
commented
May 24, 2021
|
Changed the involved messages to be more descriptive |
|
Looks good. Thanks 👍 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
before this change, rector always reports
Rector rule "%s" not found, please verify that the rule exists.no matter whether the rector rule was not found at all, or it a class was found but did not implement the proper interface